Skip to content

feat(dursto): Make ID used in Node and Tree generic#795

Open
NSant215 wants to merge 3 commits intosantnr/resolver-falliblefrom
santnr/id-generic
Open

feat(dursto): Make ID used in Node and Tree generic#795
NSant215 wants to merge 3 commits intosantnr/resolver-falliblefrom
santnr/id-generic

Conversation

@NSant215
Copy link
Contributor

@NSant215 NSant215 commented Feb 9, 2026 •
edited
Loading

Closes RV-894.
Relates to RV-892.

What

  • introduces the generic Id parameter for all functions using the Resolver to resolve an ID to the underlying object.
  • adds a test to ensure that a fallible resolver can produce the expected error.

Why

This brings us closer to enabling lazy loading of nodes.

Manually Testing

make all

Regressions

Tasks for the Author

  • Link all Linear issues related to this MR using magic words (e.g. part of, relates to, closes).
  • Eliminate dead code and other spurious artefacts introduced in your changes.
  • Document new public functions, methods and types.
  • Make sure the documentation for updated functions, methods, and types is correct.
  • Add tests for bugs that have been fixed.
  • Explain changes to regression test captures when applicable.
  • Write commit messages in agreement with our guidelines.
  • Self-review your changes to ensure they are high-quality.
  • Complete all of the above before assigning this MR to reviewers.

@NSant215 NSant215 mentioned this pull request Feb 9, 2026
Open
9 tasks
@codecov
Copy link

codecov bot commented Feb 9, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.09%. Comparing base (0e20387) to head (1561733).

Additional details and impacted files 
@@                    Coverage Diff                    @@
##           santnr/resolver-fallible     #795   +/-   ##
=========================================================
  Coverage                     91.08%   91.09%           
=========================================================
  Files                           110      110           
  Lines                         20913    20913           
  Branches                      20913    20913           
=========================================================
+ Hits                          19049    19050    +1     
+ Misses                         1491     1490    -1     
  Partials                        373      373

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NSant215 NSant215 force-pushed the santnr/id-generic branch 15 times, most recently from 3b2b234 to 374936f Compare February 11, 2026 15:24
@NSant215 NSant215 changed the base branch from main to santnr/resolver-fallible February 11, 2026 15:25
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch 2 times, most recently from e3ce608 to 1286291 Compare February 11, 2026 17:21
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 1286291 to 88cdd62 Compare February 12, 2026 08:51
@NSant215 NSant215 force-pushed the santnr/id-generic branch 2 times, most recently from 54fc0a4 to 9b75ee0 Compare February 12, 2026 11:44
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 88cdd62 to 0db6457 Compare February 12, 2026 11:44
@NSant215 NSant215 force-pushed the santnr/id-generic branch 2 times, most recently from e6c2920 to f37695c Compare February 12, 2026 14:54
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 0db6457 to 6302eda Compare February 12, 2026 15:23
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 6302eda to 2415214 Compare February 12, 2026 17:27
@NSant215 NSant215 force-pushed the santnr/id-generic branch 2 times, most recently from 34bd3e9 to f68efa1 Compare February 12, 2026 17:43
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch 2 times, most recently from b139a3b to 4807f6f Compare February 13, 2026 09:33
@NSant215 NSant215 force-pushed the santnr/id-generic branch 2 times, most recently from 5bd9e5a to a8170ad Compare February 13, 2026 09:49
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from 4807f6f to a178c3b Compare February 13, 2026 11:34
@NSant215 NSant215 force-pushed the santnr/resolver-fallible branch from a178c3b to 0e20387 Compare February 13, 2026 13:59
@NSant215 NSant215 marked this pull request as ready for review February 13, 2026 15:53
@github-actions
Copy link

github-actions bot commented Feb 13, 2026

Benchmark results for revision ceb1bbc:

Metric Duration TPS
Mean 1.530606464s 26.134
Worst 1.541828425s 25.943
Best 1.52119622s 26.295
Standard Deviation ±5.939011ms ±0.101
Full results
Run Transfers Duration TPS
1 40 1.541217609s 25.954
2 40 1.52445294s 26.239
3 40 1.541828425s 25.943
4 40 1.537198928s 26.021
5 40 1.527897243s 26.180
6 40 1.52513441s 26.227
7 40 1.538211584s 26.004
8 40 1.527746499s 26.182
9 40 1.52119622s 26.295
10 40 1.531263804s 26.122
11 40 1.525981552s 26.213
12 40 1.529631103s 26.150
13 40 1.534761951s 26.063
14 40 1.538598659s 25.998
15 40 1.525928201s 26.214
16 40 1.529938387s 26.145
17 40 1.532090865s 26.108
18 40 1.523751055s 26.251
19 40 1.527018601s 26.195
20 40 1.528281235s 26.173

Compare the results above with those for the default branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-dumitrescu victor-dumitrescu Awaiting requested review from victor-dumitrescu victor-dumitrescu is a code owner

@kurtisc kurtisc Awaiting requested review from kurtisc kurtisc is a code owner

@jobjo jobjo Awaiting requested review from jobjo jobjo is a code owner

@emturner emturner Awaiting requested review from emturner emturner is a code owner

@vapourismo vapourismo Awaiting requested review from vapourismo vapourismo is a code owner

@thomasathorne thomasathorne Awaiting requested review from thomasathorne thomasathorne is a code owner

@zcabter zcabter Awaiting requested review from zcabter zcabter is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NSant215